Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code/rows and columns #101

Merged
merged 16 commits into from
Jun 27, 2024
Merged

Code/rows and columns #101

merged 16 commits into from
Jun 27, 2024

Conversation

blythechan
Copy link
Collaborator

Issue

Requirements Met

  • Implement row and column bbcode

Notes

  • Originally, I was passing two classes together in a single attribute for columns; however, once baked or cooked the columns would have no class assigned whatsoever. I looked into this as much as I could and found that the classes were kept throughout the processing logic. I am unsure what causes it to drop the classes when there are more than one. I switched my approach by using a data parameter.
  • Default of "1" applied.

@blythechan blythechan requested review from MShultz and Alteras1 April 13, 2024 23:39
@blythechan blythechan linked an issue Apr 13, 2024 that may be closed by this pull request
@Mondrethos Mondrethos requested a review from kyuukestu May 3, 2024 01:09
@Alteras1 Alteras1 merged commit 0a5feec into main Jun 27, 2024
3 checks passed
@Alteras1 Alteras1 deleted the code/rowsAndColumns branch August 25, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BBCode Tag: Rows & Columns
4 participants