Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scroll into view #122

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Add scroll into view #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions bbcode-src/bbscript/bbscript1/functions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
/** @typedef {import('./utils').bbscriptFunc} bbscriptFunc */
/** @typedef {import('./utils').bbscriptFuncMap} bbscriptFuncMap */
/** @typedef {import('./processor').bbscriptOptions} bbscriptOptions */
import $ from "jquery";
import { bbscriptParamTypes, getStringVal, isAstNode } from "./utils";
import { ConsoleLogger } from "../logger";

Expand Down
12 changes: 11 additions & 1 deletion bbcode-src/bbscript/bbscript2/functions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
/** @typedef {import('./utils').BBScriptReturnTypes} BBScriptReturnTypes */
/** @typedef {import('./AST').ASTNode} ASTNode */
/** @typedef {import('./processor').BBScriptOptions} BBScriptOptions */
import $ from "jquery";
import { ASTError } from "./ASTError";
import { ASTIdentifier } from "./AST";
import { ConsoleLogger } from "../logger";
Expand Down Expand Up @@ -224,7 +225,6 @@ const each = (options, arr, func, token) => {
/**
* @param {BBScriptOptions} options
* @param {ASTNode | undefined} [target]
* @returns {any}
*/
const getJQueryEl = (options, target) => {
if (target !== undefined) {
Expand Down Expand Up @@ -258,6 +258,15 @@ const removeClass = (options, oldClass, target) => {
const targetEl = getJQueryEl(options, target);
targetEl.removeClass(className);
};
/**
* Scroll the target element into view
* @param {BBScriptOptions} options
* @param {ASTNode | undefined} target
*/
const scrollIntoView = (options, target) => {
const targetEl = getJQueryEl(options, target);
targetEl[0].scrollIntoView();
};
/**
* @param {BBScriptOptions} options
* @param {ASTNode | undefined} [duration]
Expand Down Expand Up @@ -814,6 +823,7 @@ export const bbscriptFunctions = {
each,
addClass,
removeClass,
scrollIntoView,
fadeIn,
fadeOut,
fadeToggle,
Expand Down
2 changes: 1 addition & 1 deletion public/javascripts/bbscript-parser.min.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion public/javascripts/bbscript-parser.min.js.map
View file
Open in desktop

Large diffs are not rendered by default.

8 changes: 8 additions & 0 deletions rollup.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,11 @@ export default [
name: "bbcodeParser",
format: "umd",
sourcemap: true,
globals: {
jquery: "$",
},
},
external: ["jquery"],
plugins: [nodeResolve(), terser({ format: { preamble: "/* Source code in bbcode-src */" } })],
watch: {
include: "bbcode-src/**",
Expand All @@ -23,7 +27,11 @@ export default [
name: "bbscriptParser",
format: "umd",
sourcemap: true,
globals: {
jquery: "$",
},
},
external: ["jquery"],
plugins: [
nodeResolve(),
terser({ format: { preamble: "/* Source code in bbcode-src/bbscript */" } }),
Expand Down