Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branding icon #25

Open
jiiins opened this issue Sep 9, 2023 · 7 comments · Fixed by home-assistant/brands#5796
Open

Branding icon #25

jiiins opened this issue Sep 9, 2023 · 7 comments · Fixed by home-assistant/brands#5796
Labels
enhancement New feature or request

Comments

@jiiins
Copy link

jiiins commented Sep 9, 2023

It looks like the integration's icon is missing, both in HACS and locally after installation.

@mastameista
Copy link

+1 same here :)

@Rudd-O
Copy link
Owner

Rudd-O commented Nov 11, 2023

I'd like that too, but it doesn't look like I control this — I think this is controlled by HACS and I tried the process, only to be rudely told no (this is a very small summary).

If anyone knows how to add the integration icon, without having to go through HACS, I would gladly do so.

@braetkuegeli
Copy link

According this blog post it must done via brands:

If this icons are ok for you, I would create a pull request:
home-assistant/brands@master...braetkuegeli:brands:master

@Rudd-O
Copy link
Owner

Rudd-O commented Aug 23, 2024

@braetkuegeli yes please. Thank you for creating the PR there. I don't have access to create PRs in that repo. When that integration is merged in the brands repo, icon will just work.

@Rudd-O
Copy link
Owner

Rudd-O commented Aug 23, 2024

Leaving this open until such a PR is merged.

@Superkikim
Copy link

I've just looked at the pull request. And frenck is complaining about the icon being from the app.

He did exactly the same for me with my maxsmart integration. I couldn't sort it out (and took it quite personally I must say).

@Rudd-O
Copy link
Owner

Rudd-O commented Sep 8, 2024

Without too many details, I've gotten perfectly working PRs rejected from HA before. I understand your frustration.

@Rudd-O Rudd-O added the enhancement New feature or request label Sep 8, 2024
@Rudd-O Rudd-O changed the title Minor: Icon Missing Branding icon Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants