From 4e491c902d4339d012d3fc6a518a84dad894ce26 Mon Sep 17 00:00:00 2001
From: Beatrice <83368538+SpaceDragon00@users.noreply.github.com>
Date: Tue, 31 Aug 2021 19:31:59 -0400
Subject: [PATCH] Admins Can Once Again Click Ban Panel Categories to Toggle
 Their Checkboxes (#60904)

* Re-Adds Header Checkboxes

- Ban Panel categories can now be clicked to click all the checkboxes in their category
- Adds a new js method called header_click_all_checkboxes whichs clicks all the checkboxes whose class is the hidden checkbox's name

Re-introduces a function that was lost with #60578 (6c4134d1eaa34f4ebbf1ea763f3d9fdb00a55620) , closes #60903 (Admins being unable to click on the ban category and check all subcheckboxes). The method was largely copied, but was changed to comply with the toggle_other_checkboxes() method introduced with the aforementioned PR by replacing a .checked assignment with a .click() call to ensure that duplicate entries are properly marked

Admins can now click categories to more easily ban people from all entries in that category. Demonstrated below to show that checkboxes are being toggled correctly in all relevant categories

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
---
 code/modules/admin/sql_ban_system.dm | 7 ++++---
 html/admin/banpanel.js               | 9 +++++++++
 2 files changed, 13 insertions(+), 3 deletions(-)

diff --git a/code/modules/admin/sql_ban_system.dm b/code/modules/admin/sql_ban_system.dm
index dc6b65d55cc2e..7d18e970f26ef 100644
--- a/code/modules/admin/sql_ban_system.dm
+++ b/code/modules/admin/sql_ban_system.dm
@@ -248,7 +248,8 @@
 		for(var/datum/job_department/department as anything in SSjob.joinable_departments)
 			var/label_class = department.label_class
 			var/department_name = department.department_name
-			output += "<div class='column'><label class='rolegroup [label_class]'>[department_name]</label><div class='content'>"
+			output += "<div class='column'><label class='rolegroup [label_class]'>[tgui_fancy ? "<input type='checkbox' name='[label_class]' class='hidden' onClick='header_click_all_checkboxes(this)'>" : ""] \
+			[department_name]</label><div class='content'>"
 			for(var/datum/job/job_datum as anything in department.department_jobs)
 				if(break_counter > 0 && (break_counter % 3 == 0))
 					output += "<br>"
@@ -275,7 +276,7 @@
 			"Abstract" = list("Appearance", "Emote", "Deadchat", "OOC"),
 			)
 		for(var/department in other_job_lists)
-			output += "<div class='column'><label class='rolegroup [ckey(department)]'>[department]</label><div class='content'>"
+			output += "<div class='column'><label class='rolegroup [ckey(department)]'>[tgui_fancy ? "<input type='checkbox' name='[department]' class='hidden' onClick='header_click_all_checkboxes(this)'>" : ""][department]</label><div class='content'>"
 			break_counter = 0
 			for(var/job in other_job_lists[department])
 				if(break_counter > 0 && (break_counter % 3 == 0))
@@ -321,7 +322,7 @@
 			),
 		)
 		for(var/department in long_job_lists)
-			output += "<div class='column'><label class='rolegroup long [ckey(department)]'>[department]</label><div class='content'>"
+			output += "<div class='column'><label class='rolegroup long [ckey(department)]'>[tgui_fancy ? "<input type='checkbox' name='[department]' class='hidden' onClick='header_click_all_checkboxes(this)'>" : ""][department]</label><div class='content'>"
 			break_counter = 0
 			for(var/job in long_job_lists[department])
 				if(break_counter > 0 && (break_counter % 10 == 0))
diff --git a/html/admin/banpanel.js b/html/admin/banpanel.js
index 3352617c5ab27..e481cd2fc2a59 100644
--- a/html/admin/banpanel.js
+++ b/html/admin/banpanel.js
@@ -8,3 +8,12 @@ function toggle_other_checkboxes(source, copycats_str, our_index_str) {
         document.getElementById(source.id.slice(0, -1) + i).checked = source.checked;
     }
 }
+
+function header_click_all_checkboxes(source) {
+	var checkboxes = document.getElementsByClassName(source.name);
+	for(var i = 0, n = checkboxes.length; i < n; i++) {
+		if(checkboxes[i].checked != source.checked && checkboxes[i] != source) {
+			checkboxes[i].click();
+		}
+	}
+}