Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error details to SpirvBuilderError::BuildError #208

Open
tombh opened this issue Jan 15, 2025 · 0 comments
Open

Add error details to SpirvBuilderError::BuildError #208

tombh opened this issue Jan 15, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@tombh
Copy link

tombh commented Jan 15, 2025

I've just come across a need in cargo-gpu to get the exact nature of the shader build failure. Namely that there is an edge case where downgrading spirv-std can cross a Rust toolchain threshold that also changes the manifest version in the shader's Cargo.lock. It'd be good to detect that error and advise the user to just delete the Cargo.lock and rebuild.

I think this would be a breaking change in the API?

I think there'd also be a way to achieve this by parsing the spirv-builder STDERR stream, but that's a bit cumbersome.

I'd be happy to look into adding this.

@tombh tombh added the enhancement New feature or request label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant