From 10443bddc26164d8cf24878746fe47897f060c79 Mon Sep 17 00:00:00 2001 From: Rohit Ashiwal Date: Thu, 1 Feb 2024 09:56:28 +0530 Subject: [PATCH] ism-plugin: fix tests (#1030) Change ... 1. 'Close indices' to 'Close' 2. 'Open indices' to 'Open' 3. 'indices' to 'indexes' 4. Sample slack webhook to meet current validation ... to match current tech writing guidelines. Signed-off-by: Rohit Ashiwal --- .../index-management-dashboards-plugin/indices_spec.js | 4 ++-- .../managed_indices_spec.js | 10 +++++----- .../notification_settings.js | 2 +- .../index-management-dashboards-plugin/rollups_spec.js | 2 +- 4 files changed, 9 insertions(+), 9 deletions(-) diff --git a/cypress/integration/plugins/index-management-dashboards-plugin/indices_spec.js b/cypress/integration/plugins/index-management-dashboards-plugin/indices_spec.js index ea255848d..723835d18 100644 --- a/cypress/integration/plugins/index-management-dashboards-plugin/indices_spec.js +++ b/cypress/integration/plugins/index-management-dashboards-plugin/indices_spec.js @@ -473,7 +473,7 @@ describe('Indices', () => { .click(); // Check for close index modal - cy.contains('Close indices'); + cy.contains('Close'); // Close confirm button should be disabled cy.get('[data-test-subj="Close Confirm button"]').should( @@ -525,7 +525,7 @@ describe('Indices', () => { .click(); // Check for open index modal - cy.contains('Open indices'); + cy.contains('Open'); cy.get('[data-test-subj="Open Confirm button"]').click(); diff --git a/cypress/integration/plugins/index-management-dashboards-plugin/managed_indices_spec.js b/cypress/integration/plugins/index-management-dashboards-plugin/managed_indices_spec.js index e6514a075..eefd530b0 100644 --- a/cypress/integration/plugins/index-management-dashboards-plugin/managed_indices_spec.js +++ b/cypress/integration/plugins/index-management-dashboards-plugin/managed_indices_spec.js @@ -58,13 +58,13 @@ describe('Managed indices', () => { }); // Confirm we got a remove policy toaster - cy.contains('Removed policy from 1 managed indices'); + cy.contains('Removed policy from 1 managed indexes'); // Wait some time for remove policy to execute before reload cy.wait(3000).reload(); // Confirm we are back to empty loading state, give 20 seconds as OSD takes a while to load - cy.contains('There are no existing managed indices.', { timeout: 20000 }); + cy.contains('There are no existing managed indexes.', { timeout: 20000 }); }); }); @@ -123,7 +123,7 @@ describe('Managed indices', () => { cy.get(`[data-test-subj="retryModalRetryButton"]`).click({ force: true }); // Confirm we got retry toaster - cy.contains('Retried 1 managed indices'); + cy.contains('Retried 1 managed indexes'); // Reload the page cy.reload(); @@ -249,10 +249,10 @@ describe('Managed indices', () => { }); // Confirm we got the change policy toaster - cy.contains('Changed policy on 1 indices'); + cy.contains('Changed policy on 1 indexes'); // Click back to Managed Indices page by clicking "Managed indices" breadcrumb - cy.contains('Policy managed indices').click(); + cy.contains('Policy managed indexes').click(); // Speed up execution of managed index cy.updateManagedIndexConfigStartTime(SAMPLE_INDEX); diff --git a/cypress/integration/plugins/index-management-dashboards-plugin/notification_settings.js b/cypress/integration/plugins/index-management-dashboards-plugin/notification_settings.js index d7562c14d..c1a22705d 100644 --- a/cypress/integration/plugins/index-management-dashboards-plugin/notification_settings.js +++ b/cypress/integration/plugins/index-management-dashboards-plugin/notification_settings.js @@ -66,7 +66,7 @@ describe('NotificationSettings', () => { config_type: 'slack', is_enabled: true, slack: { - url: 'https://sample-slack-webhook', + url: 'https://hooks.slack.com/services/sample-slack-webhook', }, }, }, diff --git a/cypress/integration/plugins/index-management-dashboards-plugin/rollups_spec.js b/cypress/integration/plugins/index-management-dashboards-plugin/rollups_spec.js index 9b2c6e616..4be179ce0 100644 --- a/cypress/integration/plugins/index-management-dashboards-plugin/rollups_spec.js +++ b/cypress/integration/plugins/index-management-dashboards-plugin/rollups_spec.js @@ -152,7 +152,7 @@ describe('Rollups', () => { cy.get('button').contains('Next').click({ force: true }); // Confirm that we got to step 4 of creation page - cy.contains('Job name and indices'); + cy.contains('Job name and indexes'); // Click the create button cy.get('button').contains('Create').click({ force: true });