Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Softcode GitHub token #10

Open
c31io opened this issue Dec 5, 2024 · 0 comments
Open

Softcode GitHub token #10

c31io opened this issue Dec 5, 2024 · 0 comments

Comments

@c31io
Copy link

c31io commented Dec 5, 2024

static GITHUB_ACCESS_TOKEN: &str = "GITHUB_ACCESS_TOKEN";

Problems:

  1. Hard-coding is a security loophole, as the token is leaked on the sharing of the code.
  2. Hard-coding makes this feature impossible to ship with binary.
  3. Users would have to install Rust toolchain.

Consider merge #4 so this repository can be packaged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant