Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read mod.conf #8

Open
S-S-X opened this issue Feb 17, 2021 · 1 comment
Open

Read mod.conf #8

S-S-X opened this issue Feb 17, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@S-S-X
Copy link
Owner

S-S-X commented Feb 17, 2021

Read name and dependencies from mod.conf if file is present.
Set modname config value default and automatically set modpaths for hard dependencies (probably to fixtures dir).

Currently there's 2 ways to set modname:

  • mineunit.conf configuration file
  • Writing directly to mineunit._config.modname

Modname is important for very basic stuff like node registration and such. Even with forced registrations testing will be more accurate if modname is correctly set.

Priority for actual modname should be:

  1. Direct writing to mineunit._config.modname.
  2. mineunit.conf configuration file.
  3. mod.conf configuration file.
@S-S-X S-S-X added the enhancement New feature or request label Feb 17, 2021
S-S-X pushed a commit that referenced this issue Feb 27, 2021
@S-S-X
Copy link
Owner Author

S-S-X commented Feb 27, 2021

Reading name from mod.conf done.

Reading dependencies require bit more work because of possible custom multi line format.
It would however be very helpful if mod paths could be set automatically for hard dependencies so that calls to minetest.get_modpath(...) would actually return expected values.

@S-S-X S-S-X added this to Mineunit Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

1 participant