New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

代码不够简洁 #4

Open

huluoyang opened this issue Jun 3, 2019 · 0 comments

huluoyang commented Jun 3, 2019

freeCodeCampProject/poker-game/lib/compare.js

Line 133 in 57ce81b

if (valueCount[value] === undefined) {

此处的两处判断逻辑完全一样，只有变量不同，不符合 DRY 原则。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment