Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change overview diagram to formal UML Class / Domain diagram. #7

Open
StanSwanborn opened this issue Apr 15, 2020 · 1 comment
Open

Comments

@StanSwanborn
Copy link
Collaborator

The semantics of the arrows is not clear at all. Do they represent calls among modules? Do they represent interface Implementations (e.g., the ones between IRUNController and the other ...RunControllers below it)?

The same applies for the nodes of this diagram. Please, use a different representation for different entities (e.g., external Python scripts, config file, internal module, etc.).

Here it could be nice also to show the robots, the necessary ROS topics and nodes, etc.

In summary: this diagram should be expanded in order to give a more detailed and comprehensive overview of what is happening in RobotRunner (and around it).

@StanSwanborn
Copy link
Collaborator Author

Also: validating config file is mentioned in the table but not implemented yet. See issue #8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant