Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add concept_name field to summary & monthly tables from pre-processing #33

Closed
andysouth opened this issue Aug 20, 2024 · 1 comment · Fixed by #32
Closed

add concept_name field to summary & monthly tables from pre-processing #33

andysouth opened this issue Aug 20, 2024 · 1 comment · Fixed by #32
Labels
improvement

Comments

@andysouth
Copy link
Contributor

as agreed in meeting 2024-08-16
Will make development & bug spotting easier.
Also will make display easier without needing to join repeatedly

Can be done by something like
left_join(select(cdm$concept, concept_id, concept_name),
by = 'concept_id')

At the end of analyse_summary_stats() & analyse_monthly_counts()
@linear Linear
Copy link

linear bot commented Aug 20, 2024

SAF-649 add concept_name field to summary & monthly tables from pre-processing

as agreed in meeting 2024-08-16
Will make development & bug spotting easier.
Also will make display easier without needing to join repeatedly

Can be done by something like
left_join(select(cdm$concept, concept_id, concept_name),
by = 'concept_id')

At the end of analyse_summary_stats() & analyse_monthly_counts()

@andysouth andysouth mentioned this issue Aug 20, 2024
Merged
@milanmlft milanmlft added suggestion What about X? improvement labels Aug 21, 2024 — with Linear
milanmlft added a commit that referenced this issue Aug 21, 2024
@milanmlft
Add concept names to summary table (#33)
cdbc9d7
milanmlft added a commit that referenced this issue Aug 21, 2024
@milanmlft
Add concept names to monthly counts table (#33)
bb345ce 
Fixes #33
milanmlft added a commit that referenced this issue Aug 21, 2024
@milanmlft
Add concept names to result tables (#33)
3ab3e6d
@stefpiatek stefpiatek removed the suggestion What about X? label Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle analysis of categorical concepts SAFEHR-data/omopcat
3 participants
@andysouth @stefpiatek @milanmlft