Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move pre-processing helper functions into the main package #34

Closed
2 tasks
milanmlft opened this issue Aug 21, 2024 · 1 comment · Fixed by #50
Closed
2 tasks

Move pre-processing helper functions into the main package #34

milanmlft opened this issue Aug 21, 2024 · 1 comment · Fixed by #50
Assignees

Comments

@milanmlft
Copy link
Member

Definition of Done / Acceptance Criteria

Relevant functions currently living in the dev/omop_analyses/ scripts have been moved into R/

Testing

  • Add unit tests for the relevant functions

Documentation

  • Properly document functions with roxygen comments

Dependencies

No response

Details and Comments

Thinking more about this, it might make sense to move the helper functions from analyse_omop_cdm.R into the package. That way they can be easily unit tested and reused in other pre-processing scripts. I'll make a new issue for that.

Originally posted by @milanmlft in #32 (comment)

Copy link

linear bot commented Aug 21, 2024

SAF-656 Move pre-processing helper functions into the main package

Definition of Done / Acceptance Criteria

Relevant functions currently living in the dev/omop_analyses/ scripts have been moved into R/

Testing

  • Add unit tests for the relevant functions

Documentation

  • Properly document functions with roxygen comments

Dependencies

No response

Details and Comments

Thinking more about this, it might make sense to move the helper functions from analyse_omop_cdm.R into the package. That way they can be easily unit tested and reused in other pre-processing scripts. I'll make a new issue for that.

_Originally posted by @milanmlft in #32 (comment)

Sorry, something went wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant