From 0124daf103d76d611635477ea04f71f78da7a5fb Mon Sep 17 00:00:00 2001 From: Johnny Shields <27655+johnnyshields@users.noreply.github.com> Date: Tue, 1 Oct 2024 03:15:40 -0400 Subject: [PATCH] Fix Rubocop on 2.x branch (#724) --- .rubocop_todo.yml | 49 ++++++++++++++++++----------------------------- 1 file changed, 19 insertions(+), 30 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index ec6b9b1d..0c8b16ab 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,6 +1,6 @@ # This configuration was generated by # `rubocop --auto-gen-config` -# on 2024-07-11 13:04:30 UTC using RuboCop version 1.64.1. +# on 2024-09-30 20:46:06 UTC using RuboCop version 1.65.0. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new @@ -68,7 +68,7 @@ Layout/ExtraSpacing: - 'lib/ruby_saml/logoutrequest.rb' - 'lib/ruby_saml/response.rb' -# Offense count: 6 +# Offense count: 8 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, IndentationWidth. # SupportedStyles: consistent, consistent_relative_to_receiver, special_for_inner_method_call, special_for_inner_method_call_in_parentheses @@ -86,7 +86,7 @@ Layout/FirstHashElementIndentation: - 'lib/ruby_saml/authrequest.rb' - 'lib/ruby_saml/metadata.rb' -# Offense count: 5 +# Offense count: 4 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: Width, AllowedPatterns. Layout/IndentationWidth: @@ -115,7 +115,7 @@ Layout/SpaceAroundEqualsInParameterDefault: - 'lib/ruby_saml/response.rb' - 'lib/ruby_saml/utils.rb' -# Offense count: 16 +# Offense count: 10 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: AllowForAlignment, EnforcedStyleForExponentOperator, EnforcedStyleForRationalLiterals. # SupportedStylesForExponentOperator: space, no_space @@ -125,9 +125,8 @@ Layout/SpaceAroundOperators: - 'lib/ruby_saml/response.rb' - 'lib/ruby_saml/utils.rb' - 'lib/ruby_saml/xml/document.rb' - - 'lib/ruby_saml/xml/signed_document.rb' -# Offense count: 3 +# Offense count: 2 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters. # SupportedStyles: space, no_space @@ -135,9 +134,8 @@ Layout/SpaceAroundOperators: Layout/SpaceInsideBlockBraces: Exclude: - 'lib/ruby_saml/idp_metadata_parser.rb' - - 'lib/ruby_saml/utils.rb' -# Offense count: 37 +# Offense count: 28 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces. # SupportedStyles: space, no_space, compact @@ -180,7 +178,7 @@ Lint/UselessAssignment: Exclude: - 'lib/ruby_saml/slo_logoutrequest.rb' -# Offense count: 41 +# Offense count: 42 # Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes. Metrics/AbcSize: Max: 100 @@ -194,39 +192,34 @@ Metrics/BlockLength: # Offense count: 8 # Configuration parameters: CountComments, CountAsOne. Metrics/ClassLength: - Max: 652 + Max: 661 -# Offense count: 26 +# Offense count: 29 # Configuration parameters: AllowedMethods, AllowedPatterns. Metrics/CyclomaticComplexity: Max: 21 -# Offense count: 58 +# Offense count: 60 # Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns. Metrics/MethodLength: - Max: 80 - -# Offense count: 1 -# Configuration parameters: CountComments, CountAsOne. -Metrics/ModuleLength: - Max: 300 + Max: 77 # Offense count: 1 # Configuration parameters: CountComments, CountAsOne. Metrics/ModuleLength: - Max: 244 + Max: 261 # Offense count: 2 # Configuration parameters: Max, CountKeywordArgs. Metrics/ParameterLists: MaxOptionalParameters: 4 -# Offense count: 24 +# Offense count: 25 # Configuration parameters: AllowedMethods, AllowedPatterns. Metrics/PerceivedComplexity: Max: 22 -# Offense count: 13 +# Offense count: 15 Naming/AccessorMethodName: Exclude: - 'lib/ruby_saml/settings.rb' @@ -297,12 +290,11 @@ Performance/StringInclude: - 'lib/ruby_saml/logoutrequest.rb' - 'lib/ruby_saml/slo_logoutresponse.rb' -# Offense count: 4 +# Offense count: 3 # This cop supports safe autocorrection (--autocorrect). Performance/StringReplacement: Exclude: - 'lib/ruby_saml/metadata.rb' - - 'lib/ruby_saml/saml_message.rb' - 'lib/ruby_saml/xml/document.rb' # Offense count: 48 @@ -397,7 +389,7 @@ Style/HashSyntax: Exclude: - 'lib/ruby_saml/settings.rb' -# Offense count: 66 +# Offense count: 65 # This cop supports safe autocorrection (--autocorrect). Style/IfUnlessModifier: Exclude: @@ -413,7 +405,6 @@ Style/IfUnlessModifier: - 'lib/ruby_saml/slo_logoutrequest.rb' - 'lib/ruby_saml/slo_logoutresponse.rb' - 'lib/ruby_saml/utils.rb' - - 'lib/ruby_saml/xml/base_document.rb' - 'lib/ruby_saml/xml/document.rb' - 'lib/ruby_saml/xml/signed_document.rb' @@ -432,11 +423,10 @@ Style/OptionalBooleanParameter: - 'lib/ruby_saml/utils.rb' - 'lib/ruby_saml/xml/signed_document.rb' -# Offense count: 3 +# Offense count: 2 # This cop supports safe autocorrection (--autocorrect). Style/RedundantRegexpArgument: Exclude: - - 'lib/ruby_saml/saml_message.rb' - 'lib/ruby_saml/xml/document.rb' # Offense count: 3 @@ -465,7 +455,7 @@ Style/StringConcatenation: - 'lib/ruby_saml/saml_message.rb' - 'lib/ruby_saml/slo_logoutrequest.rb' -# Offense count: 339 +# Offense count: 335 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline. # SupportedStyles: single_quotes, double_quotes @@ -484,7 +474,6 @@ Style/StringLiterals: - 'lib/ruby_saml/slo_logoutrequest.rb' - 'lib/ruby_saml/slo_logoutresponse.rb' - 'lib/ruby_saml/utils.rb' - - 'lib/ruby_saml/xml/signed_document.rb' # Offense count: 3 # This cop supports safe autocorrection (--autocorrect). @@ -502,7 +491,7 @@ Style/SymbolArray: Exclude: - 'lib/ruby_saml/settings.rb' -# Offense count: 104 +# Offense count: 107 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns. # URISchemes: http, https