Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Container: rename closeAlert #4124

Open
hardl opened this issue Jan 23, 2025 · 0 comments
Open

Container: rename closeAlert #4124

hardl opened this issue Jan 23, 2025 · 0 comments
Assignees
@JohannesDoberer
Labels
container ora ora related issues

Comments

@hardl
Copy link
Contributor

hardl commented Jan 23, 2025

It turned out that the name of this function is confusing, since it implies an action to close an alert, whereas its intention is to notify the container that an alert opened by it has been closed by user interaction.

  1. add additional function notifyAlertClosed with same signature as closeAlert
  2. adjust implementation to use new function
  3. change closeAlert implementation to call new function and mark it deprecated in typing
  4. adjust documentation
@hardl hardl added container ora ora related issues labels Jan 23, 2025
@JohannesDoberer JohannesDoberer self-assigned this Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JohannesDoberer JohannesDoberer

Labels
container ora ora related issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hardl @JohannesDoberer