Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds missing type declaration on luigi element #4129

Merged
merged 8 commits into from
Feb 11, 2025

Conversation

walmazacn
Copy link
Contributor

Description

Changes proposed in this pull request:

  • adds missing type declaration on luigi element
  • adds related e2e test cases

Related issue(s)

Resolves #4125

@JohannesDoberer JohannesDoberer self-assigned this Jan 28, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Contributor

@JohannesDoberer JohannesDoberer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

walmazacn and others added 2 commits February 10, 2025 10:53

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@JohannesDoberer JohannesDoberer merged commit e58c382 into main Feb 11, 2025
12 checks passed
@JohannesDoberer JohannesDoberer deleted the 4125-missing-type-declaration-on-luigi-element branch February 11, 2025 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing type declaration on luigi-element
2 participants