From 9607392b43715ab0e981915e99abfcdb6df15662 Mon Sep 17 00:00:00 2001 From: Ross Perry Date: Fri, 29 Sep 2023 08:37:56 -0600 Subject: [PATCH 1/2] eeej small files --- docker-compose.dev.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/docker-compose.dev.yml b/docker-compose.dev.yml index 897163600f..2928c20150 100644 --- a/docker-compose.dev.yml +++ b/docker-compose.dev.yml @@ -22,6 +22,7 @@ services: environment: - DJANGO_SETTINGS_MODULE=config.settings.docker_dev - DJANGO_LOG_LEVEL + - EEEJ_LOAD_SMALL_TEST_DATASET=True volumes: - ref_seed_media:/seed/media - ./seed/:/seed/seed/ From 9887c1558a5090976ac9678b18e7f249631c7ee2 Mon Sep 17 00:00:00 2001 From: Ross Perry Date: Tue, 23 Jan 2024 13:00:47 -0700 Subject: [PATCH 2/2] refactor - new program does not auto create db entry --- .../controllers/program_setup_controller.js | 56 ++++++++++--------- seed/static/seed/partials/program_setup.html | 6 +- 2 files changed, 33 insertions(+), 29 deletions(-) diff --git a/seed/static/seed/js/controllers/program_setup_controller.js b/seed/static/seed/js/controllers/program_setup_controller.js index cc2c130986..bfa9349cab 100644 --- a/seed/static/seed/js/controllers/program_setup_controller.js +++ b/seed/static/seed/js/controllers/program_setup_controller.js @@ -78,9 +78,9 @@ angular.module('BE.seed.controller.program_setup', []).controller('program_setup } if (id != null) { $scope.selected_compliance_metric = $scope.compliance_metrics.find((item) => item.id === id); - $scope.available_x_axis_columns = () => $scope.x_axis_columns.filter(({ id }) => !$scope.selected_compliance_metric?.x_axis_columns.includes(id)); - $scope.available_cycles = () => $scope.cycles.filter(({ id }) => !$scope.selected_compliance_metric?.cycles.includes(id)); } + $scope.available_x_axis_columns = () => $scope.x_axis_columns.filter(({ id }) => !$scope.selected_compliance_metric?.x_axis_columns.includes(id)); + $scope.available_cycles = () => $scope.cycles.filter(({ id }) => !$scope.selected_compliance_metric?.cycles.includes(id)); }; $scope.init_selected_metric($scope.id); @@ -212,27 +212,35 @@ angular.module('BE.seed.controller.program_setup', []).controller('program_setup return; } - // update the compliance metric - compliance_metric_service.update_compliance_metric($scope.selected_compliance_metric.id, $scope.selected_compliance_metric, $scope.org.id).then((data) => { - if ('status' in data && data.status === 'error') { - for (const [key, error] of Object.entries(data.compliance_metrics_error)) { - $scope.compliance_metrics_error.push(`${key}: ${error}`); - } - } else { - // success. the ID would already be saved so this block seems unnecesary - if (!$scope.selected_compliance_metric.id) { - $scope.selected_compliance_metric.id = data.id; - } - // replace data into compliance metric - const index = _.findIndex($scope.compliance_metrics, ['id', data.id]); - if (index >= 0) { - $scope.compliance_metrics[index] = data; + if ($scope.selected_compliance_metric.id) { + // update the compliance metric + compliance_metric_service.update_compliance_metric($scope.selected_compliance_metric.id, $scope.selected_compliance_metric, $scope.org.id).then((data) => { + if ('status' in data && data.status === 'error') { + for (const [key, error] of Object.entries(data.compliance_metrics_error)) { + $scope.compliance_metrics_error.push(`${key}: ${error}`); + } } else { - $scope.compliance_metrics.push(data); + // success. the ID would already be saved so this block seems unnecesary + if (!$scope.selected_compliance_metric.id) { + $scope.selected_compliance_metric.id = data.id; + } + // replace data into compliance metric + const index = _.findIndex($scope.compliance_metrics, ['id', data.id]); + if (index >= 0) { + $scope.compliance_metrics[index] = data; + } else { + $scope.compliance_metrics.push(data); + } + $scope.selected_compliance_metric = data; } - $scope.selected_compliance_metric = data; - } - }); + }); + } else { + // create the compliance metric + compliance_metric_service.new_compliance_metric($scope.selected_compliance_metric, $scope.org.id).then((data) => { + $scope.compliance_metrics.push(data); + $scope.init_selected_metric(data.id); + }); + } // display messages // Notification.primary({ message: 'Click here to view your Program Overview', delay: 5000 }); @@ -247,7 +255,7 @@ angular.module('BE.seed.controller.program_setup', []).controller('program_setup // create a new metric using api and then assign it to selected_compliance_metric that // way it will have an id - const template_compliance_metric = { + $scope.selected_compliance_metric = { name: 'New Program', cycles: [], actual_energy_column: null, @@ -259,10 +267,6 @@ angular.module('BE.seed.controller.program_setup', []).controller('program_setup filter_group: null, x_axis_columns: [] }; - compliance_metric_service.new_compliance_metric(template_compliance_metric, $scope.org.id).then((data) => { - $scope.compliance_metrics.push(data); - $scope.init_selected_metric(data.id); - }); //spinner_utility.hide(); } diff --git a/seed/static/seed/partials/program_setup.html b/seed/static/seed/partials/program_setup.html index 58667e3344..3b23b857b4 100644 --- a/seed/static/seed/partials/program_setup.html +++ b/seed/static/seed/partials/program_setup.html @@ -6,7 +6,7 @@

{$:: 'Program Setup' | translate $}

- + @@ -22,7 +22,7 @@

{$:: 'Program Setup' | translate $}Program
  • {$ selected_compliance_metric.name $} - +
    • @@ -38,7 +38,7 @@

      {$:: 'Program Setup' | translate $}
      • -