Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove hardcoded gpio pins in modules/deepsleep.py #113

Open
basvs opened this issue Jul 24, 2017 · 4 comments
Open

remove hardcoded gpio pins in modules/deepsleep.py #113

basvs opened this issue Jul 24, 2017 · 4 comments
Assignees
Labels

Comments

@basvs
Copy link

basvs commented Jul 24, 2017

Possible better solutions:

  • main.c
    move the methods to components/badge/

  • modules/deepsleep.py
    expose the needed pins via badge.input_pins

@basvs basvs self-assigned this Jul 24, 2017
@annejan
Copy link
Member

annejan commented Jul 24, 2017

I think we should always do the pin25 for touch wakeup thing probably in the mpr121 init . .

The bit in main.py is only for BPP afaik . . And they could/should be moved.

@basvs
Copy link
Author

basvs commented Jul 26, 2017

I couldn't find any reason not to use the input framework in main.c. I've created PR #125 for that.

@annejan annejan closed this as completed Aug 1, 2017
@basvs basvs changed the title remove hardcoded gpio pins in main.c and modules/deepsleep.py remove hardcoded gpio pins in modules/deepsleep.py Aug 3, 2017
@basvs basvs added the Low prio label Aug 3, 2017
@basvs basvs reopened this Aug 3, 2017
@basvs
Copy link
Author

basvs commented Aug 3, 2017

The modules/deepsleep.py still contains pin 25. Not very important, but it would be nice if it uses a badge.deep_sleep() or if the deepsleep.py requests which pins are used for the input.

@basvs
Copy link
Author

basvs commented Aug 16, 2017

Ok, found an issue with it. The V3-Lite badge doesn't have a mpr121 chip. Pin 25 is always low and immediately triggers a wake-up on deep-sleep.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants