-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How do we want to do the reviews? #2
Comments
Added this issue to @EIvimeyCook's repo: https://github.com/EIvimeyCook/Peer_Code/issues/1 |
Would this work? If all new issues on Ed's code are linked in this issue (which should be renamed to the something like "code review of https://github.com/EIvimeyCook/Peer_Code" ) and then addressed in the original repo...I am open to more sensible approaches too ;) |
yes thanks for starting the conversation Matt. I like the issue linking, I didn't realise you could do that! I had thought perhaps we could fork the repo in question into the org and then make issues/changes before PR'ing back into the original? |
just tried forking it into SORTEE org and that worked, but there's no option to add issues to the fork... |
Weird! This: https://stackoverflow.com/questions/16406180/is-there-a-way-to-add-issues-to-a-github-forked-repo-without-modifying-the-orig suggests it should be possible but i cant see how to do it either. ¯_(ツ)_/¯ |
So i think we might generate issues with links to the code repos that we want reviewed! If people want to later they can fork repos and submit pull requests. |
We could use a template (https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository) for the issues (like your issue Ed #4) so we have the vital information |
this template is so cool!!! thanks Matt, never seen how to do that before. Do you think we should "close with comment" the issues, or will that make them disappear? |
just tried closing it and it moves it to the closed tab... not sure what's best to do here. @DrMattG ideas? |
I think its okay to close them - they move into the closed tab but there is still a record - it will make everything a bit easier to navigate. Perhaps the code reviewee should be the one to close them (when they are happy with the review)? |
For example do we add issues/pull requests to @EIvimeyCook's repo (https://github.com/EIvimeyCook/Peer_Code) and link them to this issues? I know we will meet to discuss the code too but I thought it would be nice to have an open record of what we suggested could be changed
The text was updated successfully, but these errors were encountered: