Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Google Cast behavior with downloaded content #111

Open
defagos opened this issue Aug 8, 2019 · 1 comment
Open

Incorrect Google Cast behavior with downloaded content #111

defagos opened this issue Aug 8, 2019 · 1 comment
Labels
bug Issue to be fix (issue and PR) - release notes section

Comments

@defagos
Copy link
Member

defagos commented Aug 8, 2019

The Google Cast player is not displayed (the usual player is instead) when Google Casting a downloaded media. The media is not played on the receiver.

Issue type

Incorrect behavior

Environment information

  • Application version: 2.9.3
  • iOS version: Any
  • Device: Any

Reproducibility

Always reproducible

Steps to reproduce

  1. Open Play SRG and download an audio media.
  2. After the media has been fully downloaded, open it and play it on a Google Cast receiver.
  3. Instead of the Google Cast player being displayed, the original player is is presented, and media playback continues locally. No playback resumes on the Google Cast receiver.
@defagos defagos added maintenance Code maintenance (issue and PR) - release notes section bug Issue to be fix (issue and PR) - release notes section labels Aug 8, 2019
@defagos
Copy link
Member Author

defagos commented Aug 8, 2019

The code to deal with this special case (no media composition, only a media) has simply never been written 🙃

I see two ways of solving this issue:

  1. We implement it properly (but currently most of Google Cast setup code requires a media composition).
  2. We disable Google Cast for downloaded medias (uglier but straightforward to implement).

@pyby pyby removed the maintenance Code maintenance (issue and PR) - release notes section label Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue to be fix (issue and PR) - release notes section
Projects
None yet
Development

No branches or pull requests

2 participants