Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mini player and expired medias #134

Open
defagos opened this issue Mar 3, 2020 · 1 comment
Open

Mini player and expired medias #134

defagos opened this issue Mar 3, 2020 · 1 comment
Labels
improvement Feature or update (issue and PR) - release notes section maintenance Code maintenance (issue and PR) - release notes section

Comments

@defagos
Copy link
Member

defagos commented Mar 3, 2020

Once a media has a block reason (e.g. expired), if the play button of the mini player is tapped, nothing happens, and no UI feedback is provided to the user. The user can still tap on the mini player to open the full screen player and see that the media is expired.

Should we do something?

  • Give user some feedback when she taps on the play button? Gray it out?
  • Or hide the mini player altogether once a media has a block reason?
@defagos defagos added improvement Feature or update (issue and PR) - release notes section maintenance Code maintenance (issue and PR) - release notes section labels Mar 3, 2020
@defagos
Copy link
Member Author

defagos commented Mar 3, 2020

This issue was initially reported by @pyby during Play 3.0.0 tests. I fear that hiding the mini player when a block reason is encountered might be tricky, and possibly confusing for the user.

When testing this behavior it did not strike me as especially bad. But maybe simply graying out the button in such cases (like we do for the Google Cast) button would suffice?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Feature or update (issue and PR) - release notes section maintenance Code maintenance (issue and PR) - release notes section
Projects
None yet
Development

No branches or pull requests

1 participant