Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix minor compilation warnings #161

Open
1 of 2 tasks
defagos opened this issue Sep 28, 2020 · 1 comment
Open
1 of 2 tasks

Fix minor compilation warnings #161

defagos opened this issue Sep 28, 2020 · 1 comment
Labels
improvement Feature or update (issue and PR) - release notes section

Comments

@defagos
Copy link
Member

defagos commented Sep 28, 2020 •
edited
Loading

With migration to SPM 5.3 (Xode 12) a few compilation warnings have appeared:

  • iOS 8 is not supported as deployment target anymore. Most packages could be fixed to declare iOS 9 as minimum version. For those internally managed this is not an issue, for external packages this has to be proposed as PR.
  • SPM copies binary transitive dependencies twice because of the notification extension (though it does not reference them). This is clearly an SPM minor issue without negative consequences for us, we should report it.
@defagos defagos added the improvement Feature or update (issue and PR) - release notes section label Sep 28, 2020
@defagos
Copy link
Member Author

defagos commented Jan 7, 2022

Only UICKeyChainStore still suffers from the iOS 8 warning. All other dependencies have been updated. It is likely this issue will never be fixed as UICKeyChainStore is not really active. We could fork the project to fix the warning but I am not sure this is worth it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement Feature or update (issue and PR) - release notes section
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@defagos