Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Images not showing up on SSW Dory website #88

Closed
Jord-Gui opened this issue Nov 13, 2023 · 2 comments
Closed

🐛 Images not showing up on SSW Dory website #88

Jord-Gui opened this issue Nov 13, 2023 · 2 comments
Assignees
Labels
Area: Frontend Relates to frontend development e.g. Angular, React, XAML etc Type: Bug A problem with existing functionality

Comments

@Jord-Gui
Copy link
Member

Jord-Gui commented Nov 13, 2023

Cc: @leahy268 @ricksu978

After deployment of https://github.com/SSWConsulting/SSW.Dory/actions/runs/6843886315, images are not showing up.

Image
Figure: SSW Dory website missing images

@Jord-Gui Jord-Gui self-assigned this Nov 13, 2023
@Jord-Gui Jord-Gui added Area: Frontend Relates to frontend development e.g. Angular, React, XAML etc Type: Bug A problem with existing functionality labels Nov 13, 2023
@Jord-Gui
Copy link
Member Author

Looks like while removing next-image-optimiser, forgot to add in 'unoptimized: true' to next.config.js. This was made during the hotfix of #81. Was not picked up in staging env as you need to clear cache and refresh to see that change.

@Jord-Gui
Copy link
Member Author

Jord-Gui commented Nov 13, 2023

✅ Done - I might have jumped the gun on this one. After clearing cache and refreshing another time, the images started popping up in both staging and production environments...

Image
Figure: SSW Dory website with images

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Relates to frontend development e.g. Angular, React, XAML etc Type: Bug A problem with existing functionality
Projects
None yet
Development

No branches or pull requests

1 participant