Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selection pattern for source classes and test classes #31

Open
nrainer opened this issue Sep 11, 2018 · 3 comments
Open

Selection pattern for source classes and test classes #31

nrainer opened this issue Sep 11, 2018 · 3 comments

Comments

@nrainer
Copy link

nrainer commented Sep 11, 2018

I am wondering if there is a reason why PmpContext#getClassesInternal creates patterns for packages. Is this optimization needed?
Patterns using the full path to the Java files might be more precise for projects in which the package does not start with the name of the project (so that packages with the same name can exist in multiple projects).

@nrainer
Copy link
Author

nrainer commented Sep 14, 2018

If there is no reason against it, I think this is sensible and can reduce unnecessary analysis efforts.
For example, in the project Achilles, integration tests of different modules reside in the same package so that they would be executed in each integration test module, causing a large overhead. (https://github.com/doanduyhai/Achilles)

@nrainer
Copy link
Author

nrainer commented Sep 14, 2018

I created a pull request: #32

@Cael35
Copy link

Cael35 commented Sep 19, 2018

Because it is what PIT does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants