From 1a5ec29b119711982fad8db5eda3723e44af6f28 Mon Sep 17 00:00:00 2001 From: Vedant Date: Fri, 12 Apr 2024 11:38:01 +0530 Subject: [PATCH] Removing definition of inline variable, and modified CIs to use the correct option Signed-off-by: Vedant --- .github/workflows/linux_with_bench_test.yml | 5 +++++ .github/workflows/linux_with_nanobench_test.yml | 2 +- libs/core/testing/include/hpx/testing/performance.hpp | 2 +- 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/.github/workflows/linux_with_bench_test.yml b/.github/workflows/linux_with_bench_test.yml index a43544d43423..0dd7522661d6 100644 --- a/.github/workflows/linux_with_bench_test.yml +++ b/.github/workflows/linux_with_bench_test.yml @@ -39,3 +39,8 @@ jobs: run: | cd build ./bin/minmax_element_performance_test + - name: Test with detailed output + shell: bash + run: | + cd build + ./bin/minmax_element_performance_test --detailed_bench diff --git a/.github/workflows/linux_with_nanobench_test.yml b/.github/workflows/linux_with_nanobench_test.yml index 4409c64040e3..f8cc8213a5f3 100644 --- a/.github/workflows/linux_with_nanobench_test.yml +++ b/.github/workflows/linux_with_nanobench_test.yml @@ -45,4 +45,4 @@ jobs: shell: bash run: | cd build - ./bin/minmax_element_performance_test --hpx:verbose_bench + ./bin/minmax_element_performance_test --detailed_bench diff --git a/libs/core/testing/include/hpx/testing/performance.hpp b/libs/core/testing/include/hpx/testing/performance.hpp index 207dca784d8a..27006f552485 100644 --- a/libs/core/testing/include/hpx/testing/performance.hpp +++ b/libs/core/testing/include/hpx/testing/performance.hpp @@ -14,7 +14,7 @@ #include namespace hpx::util { - HPX_CORE_EXPORT inline bool detailed_ = false; + HPX_CORE_EXPORT inline bool detailed_; HPX_CORE_EXPORT void perftests_cfg(hpx::program_options::options_description& cmdline); HPX_CORE_EXPORT void perftests_init(const hpx::program_options::variables_map& vm); #if defined(HPX_HAVE_NANOBENCH)