From 0ba10da02cad4a74342277dcbbd39df74c546f36 Mon Sep 17 00:00:00 2001
From: Michiel de Mare <michieldemare@gmail.com>
Date: Mon, 9 Sep 2024 11:31:15 +0200
Subject: [PATCH] Review feedback

---
 .github/workflows/nvd.yml                     | 2 +-
 docker-compose.yml                            | 9 +--------
 readme.md                                     | 2 +-
 src/nl/surf/eduhub/validator/service/main.clj | 2 +-
 4 files changed, 4 insertions(+), 11 deletions(-)

diff --git a/.github/workflows/nvd.yml b/.github/workflows/nvd.yml
index 4f514ae..24f548a 100644
--- a/.github/workflows/nvd.yml
+++ b/.github/workflows/nvd.yml
@@ -23,7 +23,7 @@ jobs:
 
           # store as today's cache
           key: "nvd-clojure-${{ steps.date.outputs.date }}"
-          # if today's cache does not yet exist, fetch from whatever iss
+          # if today's cache does not yet exist, fetch from whatever is
           # the most recent cache for nvd-clojure
           # and update that
           restore-keys: "nvd-clojure-"
diff --git a/docker-compose.yml b/docker-compose.yml
index a676b9b..d682e24 100644
--- a/docker-compose.yml
+++ b/docker-compose.yml
@@ -4,16 +4,9 @@
 # SPDX-License-Identifier: Apache-2.0
 
 services:
-#
-# Prometheus will be scraping metrics.
-#
-# Goto http://localhost:9090/ to view the prometheus dashboard.
-#
   validator-service:
     build: .
     ports:
-      - "3002:3000"
+      - "3002:3002"
     env_file:
       - .envrc # read environment from local direnv settings
-    volumes:
-      - ./shared:/shared # writeable directory where gateway.config.yml is kept
diff --git a/readme.md b/readme.md
index ea8dd6b..20cbb62 100644
--- a/readme.md
+++ b/readme.md
@@ -29,7 +29,7 @@ GATEWAY_BASIC_AUTH_PASS=PASS
 make
 java -jar target/eduhub-validator-service.jar
 # To test:
-curl -v 'http://localhost:3000/endpoints/demo04.test.surfeduhub.nl/config'
+curl -v 'http://localhost:3002/endpoints/demo04.test.surfeduhub.nl/config'
 ```
 
 
diff --git a/src/nl/surf/eduhub/validator/service/main.clj b/src/nl/surf/eduhub/validator/service/main.clj
index 27af194..bb79209 100644
--- a/src/nl/surf/eduhub/validator/service/main.clj
+++ b/src/nl/surf/eduhub/validator/service/main.clj
@@ -57,4 +57,4 @@
     (run-jetty (-> app-routes
                    (wrap-validator config)
                    (wrap-defaults api-defaults)
-                   wrap-json-response) {:port 3000})))
+                   wrap-json-response) {:port 3002})))