Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unvalidated http-->https redirect #21

Closed
baszoetekouw opened this issue Jan 12, 2024 · 1 comment
Closed

Unvalidated http-->https redirect #21

baszoetekouw opened this issue Jan 12, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@baszoetekouw
Copy link
Member

de guacomole host (pilot1) doet unvalidated http-->https redirects (maw: hij redirect je vriendelijk naar whatever host je in je HTTP Host header stopt, ook als hij die host niet zelf serveert):

╰─▶ telnet pilot1.sram.surf.nl 80
Trying 145.101.114.5...
Connected to pilot1.sram.surf.nl.
Escape character is '^]'.
GET / HTTP/1.1
Host: evilserver.com

HTTP/1.1 301 Moved Permanently
Location: https://evilserver.com/
Date: Fri, 12 Jan 2024 15:36:51 GMT
Content-Length: 17
Content-Type: text/plain; charset=utf-8

Moved Permanently
@HarryKodden
Copy link
Member

issue confirmed

curl --request GET \
  --url http://proxy.pilot1.sram.surf.nl/ping \
  --header 'host: evilserver.com'

Adjust Treafik config

old:

  - "traefik.http.routers.httpCatchall.rule=HostRegexp(`{any:.+}`)"

new:

  - "traefik.http.routers.httpCatchall.rule=HostRegexp(`{any:.+}.pilot1.sram.surf.nl`)"

@HarryKodden HarryKodden moved this from Todo to Done in SRAM development Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

2 participants