Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate free memory on minions #170

Open
jschmid1 opened this issue Mar 27, 2017 · 5 comments
Open

validate free memory on minions #170

jschmid1 opened this issue Mar 27, 2017 · 5 comments
Labels

Comments

@jschmid1
Copy link
Contributor

librados will return 1, can't fill zero pages, if your machine has not enough(<= 50mb) memory left.

ran into this on a VM setup some time back. Implementing a validation as part of a (custom)grain could be helpful

@BlaineEXE
Copy link
Contributor

Is there a way we can not hardcode the 50mb number? Can Ceph output the amount of memory it needs to fulfill librados requests that we could store that as a grain?

Even if we do have to hardcode, it would be nice to warn the user that they are getting low on memory before they get critically low.

@jschmid1
Copy link
Contributor Author

I think this doesn't limit to librados calls, but to all commands that will be executed on minions.
So having salt telling the user that minions are short on memory would be a benefit

@tserong
Copy link
Member

tserong commented Mar 31, 2017

How much RAM was allocated to the VM in total? I tend to run into trouble with anything less than 2GB. Also, this is probably more an issue for dev/test, where we might be using tiny machines, than for "real" deployments, right?

@jschmid1
Copy link
Contributor Author

jschmid1 commented Apr 3, 2017

How much RAM was allocated to the VM in total?

2GB

I think this is not only limited to dev/test env. That is just one of these checks we should do before executing certain tasks in order to avoid undefined behavior. The ideal solution would be ofc to passthrough the exception that librados throws, but imho we can't solely rely on salt here.

@swiftgist
Copy link
Contributor

To address this issue, maybe a man page for odd, cryptic errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants