Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test data is very outdated #177

Open
JBorrow opened this issue Oct 30, 2023 · 6 comments
Open

Test data is very outdated #177

JBorrow opened this issue Oct 30, 2023 · 6 comments

Comments

@JBorrow
Copy link
Member

JBorrow commented Oct 30, 2023

Our test data is extremely outdated. This means the test suite passes when some of our features don't work with new data (e.g. subset snapshots).

We need to re-run the small cosmo volume and update the data on cosma dataweb.

@MatthieuSchaller
Copy link
Member

Do you need me to run or store things somewhere?

@JBorrow
Copy link
Member Author

JBorrow commented Nov 1, 2023

Our example data (described here) is super old... If you could try running the smalcosmovolume again and updating the data that would be great. Could also be a good first-student-project seeing as it's that time of year

https://swiftsimio.readthedocs.io/en/latest/loading_data/index.html

@MatthieuSchaller
Copy link
Member

You have full ownership of that data server-side. I can't overwrite it.

/cosma5/data/Swift/web-storage/IOExamples

@JBorrow
Copy link
Member Author

JBorrow commented May 8, 2024

I've changed them to allow swift group write access.

@MatthieuSchaller
Copy link
Member

Ok. Do you need me to make the changes above or are you doing it?

@JBorrow
Copy link
Member Author

JBorrow commented May 17, 2024

Nobody 'needs to' but someone should do it at some point. Good thing to give a grad student as their first mini project (requires running a small cosmo volume etc.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants