Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signature help does not always correctly highlight the current argument when using keyword arguments #1088

Open
2 tasks done
FerretDetective opened this issue Jan 26, 2025 · 2 comments
Labels
bug Something isn't working signature Related to the signature help

Comments

@FerretDetective
Copy link
Contributor

Make sure you have done the following

  • Updated to the latest version of blink.cmp
  • Searched for existing issues and documentation (try <C-k> on https://cmp.saghen.dev)

Bug Description

When using keyword arguments in a language like python the order in which they are specified does not matter. When using blink, inputting keyword arguments that are out of order from the definition causes the wrong argument to be highlighted as the current.

Neovim with blink.cmp:
Image

VSCode:
Image

Relevant configuration

signature = { enabled = true }

neovim version

NVIM v0.10.3 Build type: RelWithDebInfo LuaJIT 2.1.1731601260 Run "nvim -V1 -v" for more info

blink.cmp version

v0.11.0

@FerretDetective FerretDetective added the bug Something isn't working label Jan 26, 2025
@Saghen Saghen added the signature Related to the signature help label Jan 26, 2025
@Saghen
Copy link
Owner

Saghen commented Jan 26, 2025

Are you using the same LSP on both?

@FerretDetective
Copy link
Contributor Author

Yes, I was using basedpyright for both.

I just tested it again, and it seems to behaving differently. When I reported this it seemed to occur whether or not I accepted the completion for the keyword argument (sep), but now it seems wrong only when I don't accept the completion.

The first one I don't accept the completion, and the second one I do:

Screencast_20250126_094704.webm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working signature Related to the signature help
Projects
None yet
Development

No branches or pull requests

2 participants