Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestion: add line breaks to about me content #2

Open
JuliaMathias opened this issue Jul 10, 2021 · 0 comments
Open

suggestion: add line breaks to about me content #2

JuliaMathias opened this issue Jul 10, 2021 · 0 comments

Comments

@JuliaMathias
Copy link

Hi! First of all, thank you so much for creating this theme! I ran into some problems when I was trying to change the about me section so I would like to suggest some changes. I tried opening a pull request but I guess this repository doesn't accept prs from random people? I'm sorry, I'm still kind of a new dev and have never tried to contribute to a repo of someone I didn't know.

Basically I ran into two problems: first the content field on src/data/hero/index.md is wrapped by single quotes, so any time you write something like "I'm a develeper" it breaks because of the single quote in I'm. So my first suggestion is to simply change it to double quotes like:

---
category: 'hero section'
title: 'Frontend Developer'
subtitle: 'I am the Great Gatsby'
content: "Lorem Ipsum is simply dummy text of the printing and typesetting industry. Lorem Ipsum has been the industry standard dummy text ever since the 1500s, when an unknown printer took a galley of type and scrambled it to make a type specimen book."
linkTo: '/resume/'
linkText: 'View My Profile'
---

Second, on my site, I wanted to write a bit more in this section, and actually have two paragraphs. I thought maybe other people would want that as well, so these are my suggestion to implement that:

src/components/ui/Banner/styles.js

export const Content = styled.div`
  ${tw`mb-8 whitespace-pre-wrap`};
`;

I hope I'm not being rude by suggesting these changes. I just thought that maybe other people would also want line-breaks like me but might not have the patience to search for the solutions for that. Once again, thanks for all the work you did on this gatsby starter!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant