Is it really okay to have one controller per "use-case" or command/query?

[paulwongx]

I really appreciate this document and trying to stick to it, but when I ask ChatGPT about one controller per command/query (in your words it's per "use-case"), it recommends grouping the routes together to have one or a few controllers per module as opposed to essentially one for every endpoint.

Wouldn't there be a bit of a performance impact if I had hundreds of controllers since I have hundreds of routes for example? Or is the clear vertical slice a high priority and sufficiently beneficial so we should stick to having one http controller for each command/query over performance/overhead concerns?

Just wondering if you could provide some more commentary on this.

As a basic example... from copying your repo and reading the document, it would seem we should have one http controller for each of the routes below?

So out of all the possibilities:
a) 2 controllers - 1 for auth, 1 for mfa
b) 3 controllers - 1 for auth, 1 for oauth, 1 for mfa
c) 15 controllers - combine them in each of their modules when registering it and it's okay to have hundreds in the whole app

To clarify, you would still recommend (c) right? @Sairyss

/** AUTH ROUTES */
const AUTH_LOGIN_CREDENTIALS = ["POST", "/auth/login/credentials"];
const AUTH_LOGOUT = ["POST", "/auth/logout"];
const AUTH_REGISTER = ["POST", "/auth/register"];
const AUTH_RESET_PASSWORD = ["POST", "/auth/reset-password"];
const AUTH_OAUTH_GITHUB_CALLBACK = ["GET", "/auth/oauth/github/callback"];
const AUTH_OAUTH_GOOGLE_CALLBACK = ["GET", "/auth/oauth/google/callback"];


/** MFA ROUTES */
const MFA_GET_MFA_STATUS = ["GET", "/users/mfa/status"];
const MFA_LIST_MFA_FACTORS = ["GET", "/users/mfa/factors"];
const MFA_REMOVE_MFA_FACTOR = ["POST", "/users/mfa/factors/remove"];
const MFA_CHANGE_PRIMARY_FACTOR = ["POST", "/users/mfa/factors/change-primary"];
const MFA_GENERATE_TOTP = ["POST", "/users/mfa/totp/generate"];
const MFA_VERIFY_TOTP = ["POST", "/users/mfa/totp/verify"];
const MFA_LIST_RECOVERY_CODES = ["GET", "/users/mfa/recovery-codes"];
const MFA_GENERATE_RECOVERY_CODES = ["POST", "/users/mfa/recovery-codes/generate"];
const MFA_VERIFY_MFA = ["POST", "/users/mfa/verify"];

[Sairyss]

I didn't say there has to be 1 controller per 1 endpoint, just that modules and use-cases have to be grouped by functionality. How to group them is up to you. You can create 1 controller per module if you prefer and put all endpoints there.

[paulwongx]

Thanks for your response. I prefer what you have in your example repo where it's ending up as one controller per "use case" or route it seems, but just curious if in real world apps people do it that way and if that's "okay" or common to have hundreds of controllers.

I'm moreso looking for guidance as opposed to planting a flag on a hill. If it were up to you, would you create 15 controllers in the example above?

[Sairyss]

In your case, I would probably create 1 controller per module since the functionality is closely related (register/login/logout/etc).
I'd recommend trying out different approaches and deciding for yourself what is easier for you to work with. There is no one rule fits all solution.