-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Evaluation on Time-Series with all NaN targets #12
Comments
Hi @liam-sbhoo, Thanks for raising this point! I agree, that this is a problematic instance that our dataset builder framework did not filter.
We allow for missing values in the historical context, however, the instance you have found is exceptional because all values are missing in the historical context. I agree this is not ideal and preferably should have been filtered from the dataset. After you raised the issue I checked to see how many such instances we have in the whole gift_eval and I found only one more in addition to the one you shared:
So to answer your question whether these instances dominate the results or not, I believed they would not. The reason is (1) its a very small portion in their respective datasets, and (2) we normalize each model's result on every dataset with seasonal_naive. However, just to be sure I replicated the results for one model (moirai_small) with and without exlcuding the problematic instances for both datasets. You can see the results below: Electricy/W, Short
bitbrains_fast_storage/H, Short
The difference after normalization with seasonal naive seems to be very small at least for the moirai model. |
Hey there!
While evaluating on some of the datasets (e.g.
electricity/W
), in the test data, I can see that some time series only contain NaN targets (see the screenshot below). I'd expect the score on these time series would dominate the overall score.Any thoughts on this?
Or is there any normalization in the scores that make the scores on these time-series less "disruptive"?
Thank you in advance! 😄
The text was updated successfully, but these errors were encountered: