From 1aa09194b0436e7b4276457f63aed5304640efd5 Mon Sep 17 00:00:00 2001 From: Sanggyu Lee Date: Fri, 1 Sep 2023 23:57:34 +0900 Subject: [PATCH] [onert] Revisit ConvolutionLayer.h (#11443) It makes methods private as much as possible. Also, it reorders the methods to make it easy to read. ONE-DCO-1.0-Signed-off-by: Sanggyu Lee --- runtime/onert/backend/cpu/ops/ConvolutionLayer.h | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/runtime/onert/backend/cpu/ops/ConvolutionLayer.h b/runtime/onert/backend/cpu/ops/ConvolutionLayer.h index 9f5253c8eac..3d018c411a2 100644 --- a/runtime/onert/backend/cpu/ops/ConvolutionLayer.h +++ b/runtime/onert/backend/cpu/ops/ConvolutionLayer.h @@ -48,13 +48,6 @@ class ConvolutionLayer : public ::onert::exec::IFunction ~ConvolutionLayer(); public: - void convFloat32(); - - void convQ8uPerTensor(); - void convQ8uPerChannel(); - - void convQ8i(); - void configure(const IPortableTensor *input, const IPortableTensor *kernel, const IPortableTensor *bias, ir::PaddingType _paddingType, const uint32_t paddingLeft, const uint32_t paddingRight, const uint32_t paddingTop, @@ -62,10 +55,14 @@ class ConvolutionLayer : public ::onert::exec::IFunction const uint32_t strideHeight, const uint32_t dilationWidthFactor, const uint32_t dilationHeightFactor, const ir::Activation activation, IPortableTensor *output); - + void prepare() override; void run() override; - void prepare() override; +private: + void convFloat32(); + void convQ8uPerTensor(); + void convQ8uPerChannel(); + void convQ8i(); private: const IPortableTensor *_input;