-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Question] How to use / am I missing something? #15
Comments
Hi, Could you let us know a more detailed situation? And It would be better if you could give us browser and node-red runtime logs. Thank you! |
@shgood well I actually saw the list of devices in Status or Event nodes once and I am unable to simulate it again. Since now, I always get an empty select boxes. I tried to uninstall the plugin, but that did not help. Please see attached files, to clarify my problem. For example, if I open the Command node, the list of devices exists. By the way, what is the best way for you to get you the node-red runtime log? How to access it please? I am running node-red on Raspi 4, Homebridge image: Browser/PC: |
@shgood Hi, bellow are the print-screens. Hope it helps. Martin ReferenceError: addTitle is not defined |
Hi, please, install node-red 1.3.2 or 1.3.3. |
@shgood YES!! 🙌 👏 👍 this fixed the issue.. May I ask one more question? Does it mean, I have to have each device on separate flow? Its not problem for me, but just asking. If I create flow, select My device node and select 2 devices, when I use Event/Status node, I only get active the first one and the rest is disabled. Thank you, Martin |
No, you don't need to. If a device is disabled on the select, that device is not an appropriate device used by Event/Status/Command node. It means that there are some conditions. And when you hover mouse over the disabled select option, you can see the reason why the device is disabled. |
@shgood see my trouble. If I create flow, select My Device, then select 2 devices, deploy. Then I add Event node and only first device is selected. If I open the device select, all devices are disabled (see print-screen)... So I can only work with the one preselected.. Now, I have 2 flows, where in both I select different Device in My device node.. By adding Event node to each flow, I have correctly preselected device and I can work with it.. yet still all devices are disabled when I open the select. |
The current behavior seems to be a bug in a safari browser. But. as I said, event-device node work with "automation" node only. Please, use status-node instead of event-node to get device status. |
@shgood after upgrade to 1.1.7 this behaviour still exists |
Hi, @kudlaaaty , @RitaSghe. 1.1.9 version has been released today to fix SmartThings my-device bug. Please, update and use the new version. |
@shgood |
After re-open node-red, Your my-device node's properties all disappear ?? even a 'Personal Access Token'? If there are console error messages, could you let me know that or your server error messages? |
After 9 days not news? |
* fix : mydevice info api bug #15 (#28) * fix : mydevice info api bug * modify : package.json version * modify : modify 'undefined' room name to 'Unknown' * fix : smartthings mydevice api call, node-red http-node-root (#30) node-red httpNodeRoot 설정, my-device API 호출시 적용 * modify : package.json version 1.1.10
Hi, 404 error is occurring, I think that it is related to node-red's 'httpNodeApp' root setting. Please update version '1.1.10' and check. |
After update to 1.1.10 the bug is fixed ...... |
@shgood I've tried in different browsers but without success. |
Any chances to get this bug rid off? Currently, because of this bug almost whole palette is unusable |
@shgood after upgrade to 1.1.11 error still exists: |
@RitaSghe Are you using node-red 'adminAuth' option in 'setting.js'? Regarding that, the 1.1.11 version was released. Please update version '1.1.11' and check. |
It seems that your node-red path and httpNodeRoot path are different. I think that maybe your node-red is running on k8s. so, modify the path to your node-red path in the '101-SmartThings.js' file code. SamsungAutomationStudio/101-SmartThings.js Lines 38 to 39 in 6390676
OR try to change in the '101-SmartThings.html' file code SamsungAutomationStudio/101-SmartThings.html Line 765 in 6390676
to
|
@shgood I've found that the correct URL is: I've change the path as follows but still node wants to read directly from "endpoint/_smartthings/mydevices" |
Hmm.. SamsungAutomationStudio/101-SmartThings.html Lines 763 to 777 in 6390676
Please try to change code like below (rollback '101-SmartThings.html') //line 765
const root = '{your node-red path}'; e.g. const root = '/api/hassio_ingress/2WYIo6nZdNVGqcJBLblrmI1_B8pC9V2wVTyz8Jjj7ek/endpoint/'
// or const root = 'api/hassio_ingress/2WYIo6nZdNVGqcJBLblrmI1_B8pC9V2wVTyz8Jjj7ek/endpoint/' |
@shgood do the trick! Thanks! |
I have update version '1.1.11' and nothing has changed and yes, I use node-red 'adminAuth' option with admin and password .... Double click on the List device node and I have this situation: So single click on the red check and I have this situation: Single click on button Cancel and Double click on the List device node again and I have this situation, the real correct list of devices: Now I click done and after Deploy. Now Double click on the List device node and I have this situation: Nothing has changed .... |
@kudlaaaty , @RitaSghe could you try this code? SamsungAutomationStudio/101-SmartThings.html Lines 763 to 775 in 6390676
change 'callMyDeviceApi' function to below code function callMyDeviceApi(path){
return new Promise((resolve,reject)=>{
let root = RED.settings.httpNodeRoot||'';
root = root.trim().replace(/^\/*/,'');
if(/[^\/]$/.test(root)){root+='/';}
$.ajax({url:root+path,type:"GET",dataType:'json'}).then(resolve,reject);
})
} If it works, I will modify the code. |
@shgood |
Try to restart ... :) |
@RitaSghe |
@RitaSghe 'restart' means 'node-red server restart' or 'browser close and open'? And your raspberry can connect SmartThings API? |
@kudlaaaty |
I mean restart node-red server ... and I think raspberry is connected with SmartThings API because the node work fine, the problem for me is only the correct list of device .... |
Yes, I've restarted whole node-red. AFAIK Rapsberry itself does not interact with ST API |
You can look the other way, but this don't fix the problem ..... |
Rename/log node
모듈 이름 중복 체크 여러가지 테스트 Co-authored-by: 김성현 <[email protected]>
Hi, I have Raspi 4 with Node-RED installed. I have installed this plugin to enable me to connect to Smartthings cloud and obtain status of my Samsung Washer and Samsung Dryer. When I create a new flow, add My device node - fill in the token, I get the list of my devices. I unselect all and chose only 1 (for example Samsung Washer), then I deploy. After that, I add status or event node and sometimes I can choose the appropriate selects, but most of the time they are empty...
Any hints please?
Thank you, Martin
The text was updated successfully, but these errors were encountered: