fix(clang_format_analyzer): create parent folders for target file #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i-keliukh
reviewed
Feb 5, 2024
tests/test_code_report.py
Outdated
|
|
||
|
|
||
| @pytest.mark.parametrize('analyzer, extra_args, tested_content', [ | ||
| ['clang_format', ["--report-html"], source_code_c], |
There was a problem hiding this comment.
You are not checking html file after running clang_format, so you don't need to add the --report-html parameter.
BTW, the html generation is already checked in another test.
i-keliukh
reviewed
Feb 5, 2024
tests/test_code_report.py
Outdated
|
|
||
| log = runner_with_analyzers.run(ConfigData().add_analyzer(analyzer, args, extra_config).finalize()) | ||
| assert not re.findall(r'No such file or directory', log), f"'No such file or directory' is found in '{log}'" | ||
| assert re.findall(log_fail, log), f"'{log_success}' is not found in '{log}'" |
There was a problem hiding this comment.
The assert message doesn't match the assert condition. Please fix the message or the condition.
i-keliukh
reviewed
Feb 5, 2024
tests/test_code_report.py
Outdated
| @@ -405,3 +405,29 @@ def test_code_report_extended_arg_search_embedded(tmp_path: pathlib.Path, stdout | |||
|
|
|||
| env.run() | |||
| stdout_checker.assert_absent_calls_with_param("${CODE_REPORT_FILE}") | |||
|
|
|||
|
|
|||
| @pytest.mark.parametrize('analyzer, extra_args, tested_content', [ | |||
There was a problem hiding this comment.
Now you don't need to parametrize the test, because you only have one set of parameter values.
There was a problem hiding this comment.
Thank you, removed
i-keliukh
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #837
Added creation of directories before opening a file in universum/analyzers/clang_format.py:43
Checklist: