You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is then executed by the default shell on the supervisor. In most cases this is fine, but if either of the paths contains a space, the command will turn into dut_copyto.sh path with spaces other_path. The implementation of dut_copyto will throw an error in best case or do something unexpected in worst case (consider CopyFilesTo([]string{"random_file /etc/passwd"}, "what_if_this_path_is_ignored")).
This issue also affects SupervisorPull/Push in my changes.
The text was updated successfully, but these errors were encountered:
Copying files from/to DUT is currently implemented as
weles/manager/dryad/device_communication_provider.go
Lines 57 to 59 in 0473c47
and even though
sessionProvider.Exec
takes the command in the form of a list of strings, it proceeds then to justweles/manager/dryad/session_provider.go
Line 148 in 0473c47
This is then executed by the default shell on the supervisor. In most cases this is fine, but if either of the paths contains a space, the command will turn into
dut_copyto.sh path with spaces other_path
. The implementation of dut_copyto will throw an error in best case or do something unexpected in worst case (considerCopyFilesTo([]string{"random_file /etc/passwd"}, "what_if_this_path_is_ignored")
).This issue also affects SupervisorPull/Push in my changes.
The text was updated successfully, but these errors were encountered: