-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
U2FServer::createChallenge() fails in PHP 7.4 #6
Comments
Hey, thank you for this. I have another method of generating random bytes, I will implement a fix for this. |
As you can see on https://github.com/code-lts/U2F-php-server/runs/1332881031?check_suite_focus=true in #9 this seems to run fine. Maybe you have an idea why ? |
@Samyoul if we agree to be supporting only php 7 and upwards we could switch to https://www.php.net/manual/en/function.random-bytes.php else add a fallback onto it for php 7+ versions |
@MauricioFauth I can not reproduce this, nor the tests |
I remember it appeared in phpMyAdmin's testsuite, but I don't know how to reproduce it now. |
Samyoul\U2F\U2FServer\U2FServer::createChallenge()
always throws an exception in PHP 7.4.openssl_random_pseudo_bytes
has changed in PHP 7.4.See RFC: https://wiki.php.net/rfc/improve-openssl-random-pseudo-bytes
The text was updated successfully, but these errors were encountered: