Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Method to add PackURL Without In-Memory Download of Resource Pack #212

Open
EinBexiii opened this issue Nov 6, 2023 · 0 comments
Open

Comments

@EinBexiii
Copy link

Description

The current implementation, as seen in the method at pack.go, stores the pack in the server's memory, which can be problematic for servers with restricted memory capacity, particularly on devices with RAM limitations such as Android.

Problem

Servers with limited RAM are at risk of crashing when handling large resource packs (100MB+), as the current method reads all bytes into memory.

Proposed Solution

To circumvent this limitation, I propose the addition of a new method that allows to provide only the PackURL and validating without downloading the pack. This new method should:

  • Validate the provided PackURL to ensure it's a valid and reachable URL.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant