Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test suite needs to be updated to look for broker_settings.yaml in ~/.broker #212

Closed
Griffin-Sullivan opened this issue May 10, 2023 · 3 comments · Fixed by #287
Closed

Test suite needs to be updated to look for broker_settings.yaml in ~/.broker #212

Griffin-Sullivan opened this issue May 10, 2023 · 3 comments · Fixed by #287
Assignees
@Griffin-Sullivan

Comments

@Griffin-Sullivan
Copy link
Collaborator

Currently, the tests are hard coded to search for broker_settings.yaml in the root directory of broker. After #206, we now need to look for the file in ~/.broker/. See #211 for an example.
@Griffin-Sullivan Griffin-Sullivan self-assigned this May 10, 2023
@Griffin-Sullivan Griffin-Sullivan mentioned this issue May 26, 2023
Closed
@tpapaioa tpapaioa mentioned this issue Apr 19, 2024
Merged
@Gauravtalreja1
Copy link

@tpapaioa @JacobCallahan Can this issue be closed as completed?

@JacobCallahan JacobCallahan added 0.6 and removed 0.6 labels Sep 12, 2024
@JacobCallahan
Copy link
Member

@Gauravtalreja1 on second look, yes. There is a larger issue around config files used in testing that will be resolved later.

@ogajduse
Copy link
Member

@JacobCallahan Can you please link the PR that resolved it for better traceability?

@JacobCallahan JacobCallahan linked a pull request Sep 13, 2024 that will close this issue
Update functional tests to use correct broker settings location #287
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Griffin-Sullivan Griffin-Sullivan

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@JacobCallahan @ogajduse @Gauravtalreja1 @Griffin-Sullivan