Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider generalizing ifconfig_ioctlwrap #45

Open
asomers opened this issue May 1, 2017 · 2 comments
Open

Consider generalizing ifconfig_ioctlwrap #45

asomers opened this issue May 1, 2017 · 2 comments

Comments

@asomers
Copy link
Contributor

asomers commented May 1, 2017

ifconfig_ioctlwrap conveniently opens the right socket type and sets all of the error fields, but it only works for ioctls where the data field has type struct ifreq. I'm finding that the majority of ioctls I need to use don't use that data type. Would you agree to change ifconfig_ioctlwrap's fourth argument to an opaque void*?

@Savagedlight
Copy link
Owner

Can you provide some example code which would benefit from making this change?

@Savagedlight
Copy link
Owner

Savagedlight commented May 4, 2017

Sounds reasonable, especially considering the underlying method it's abstracting. Thank you. :)

I'll get around to processing this coding spree of yours once my dev environment is back up and running!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants