Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return models rather than json #14

Open
dylanmcreynolds opened this issue Apr 27, 2022 · 1 comment
Open

Return models rather than json #14

dylanmcreynolds opened this issue Apr 27, 2022 · 1 comment

Comments

@dylanmcreynolds
Copy link
Collaborator

The input methods in the scicat client like, say, upload_dataset take model objects as input (for validation).

However, the retrieval methods like get_sets return dictionaries. (note that that particular function is currently mis-typed), claiming that it returns List[Dataset].

@nitrosx has noted that if this returned model objects, then it would be a little easier for the API user to navigate. This would be an easy change to make, but would be a breaking change unless we add parameter like return_raw=False to the methods.

Curious if these methods have been adopted yet. @toqduj , do you use them?

@toqduj
Copy link
Collaborator

toqduj commented May 6, 2022

I don't think I'm using those returned values yet, so you can go ahead and make the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants