Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QRFactorization throws when given singular matrices #489

Closed
oscardssmith opened this issue Apr 2, 2024 · 1 comment
Closed

QRFactorization throws when given singular matrices #489

oscardssmith opened this issue Apr 2, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@oscardssmith
Copy link
Contributor

this gives a LAPACKException because A is singular and QRFactorization defaults to NoPivot instead of ColumnNorm.

using LinearSolve
A = vcat(rand(1,2), zeros(2,2)), rand(3))
solve(LinearProblem(A, QRFactorization())

I'm not sure if there's a good way to detect whether the factorization is singular in this case, but we should do so and return a failure rather than throw an error.

@oscardssmith oscardssmith added the bug Something isn't working label Apr 2, 2024
@avik-pal
Copy link
Member

Fixed in the latest release

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants