From 9909f91a71f0a7a76f9973819bd9d641b7df4ab7 Mon Sep 17 00:00:00 2001 From: Maxime GRANDCOLAS Date: Thu, 31 Oct 2024 10:33:17 +0100 Subject: [PATCH] [MS] Add external profile tag in workspace sharing --- client/src/components/workspaces/WorkspaceUserRole.vue | 7 ++++++- client/tests/pw/e2e/workspace_sharing.spec.ts | 2 ++ newsfragments/8245.feature.rst | 1 + 3 files changed, 9 insertions(+), 1 deletion(-) create mode 100644 newsfragments/8245.feature.rst diff --git a/client/src/components/workspaces/WorkspaceUserRole.vue b/client/src/components/workspaces/WorkspaceUserRole.vue index 2c66ca8a18a..81306628ef8 100644 --- a/client/src/components/workspaces/WorkspaceUserRole.vue +++ b/client/src/components/workspaces/WorkspaceUserRole.vue @@ -13,6 +13,11 @@ > {{ $msTranslate('UsersPage.currentUser') }} + + import { MsAppearance, MsDropdown, MsOption, MsOptions } from 'megashark-lib'; -import UserAvatarName from '@/components/users/UserAvatarName.vue'; +import { TagProfile, UserAvatarName } from '@/components/users'; import { canChangeRole } from '@/components/workspaces/utils'; import { UserProfile, UserTuple, WorkspaceRole } from '@/parsec'; import { getWorkspaceRoleTranslationKey } from '@/services/translation'; diff --git a/client/tests/pw/e2e/workspace_sharing.spec.ts b/client/tests/pw/e2e/workspace_sharing.spec.ts index 90693a7d32c..cd07cf9572d 100644 --- a/client/tests/pw/e2e/workspace_sharing.spec.ts +++ b/client/tests/pw/e2e/workspace_sharing.spec.ts @@ -14,6 +14,8 @@ msTest('Workspace sharing modal default state', async ({ workspaceSharingModal } // cspell:disable-next-line await expect(users.locator('.person-name')).toHaveText(['Gordon Freeman', 'Korgan Bloodaxe', 'Jaheira']); await expect(users.locator('.filter-button')).toHaveText(['Owner', 'Reader', 'Not shared']); + await expect(users.nth(2).locator('.label-profile')).toBeVisible(); + await expect(users.nth(2).locator('.label-profile')).toHaveText('External'); await expect(users.nth(0).locator('.filter-button')).toHaveDisabledAttribute(); }); diff --git a/newsfragments/8245.feature.rst b/newsfragments/8245.feature.rst new file mode 100644 index 00000000000..98acc643e4b --- /dev/null +++ b/newsfragments/8245.feature.rst @@ -0,0 +1 @@ +Added an indication that the user is an outsider when sharing a workspace