-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[🐛 Breaking change]: Harmonized configuration mount point between docker images to /opt/selenium/config.toml #2340
Comments
@Trigtrig, thank you for creating this issue. We will troubleshoot it as soon as we can. Info for maintainersTriage this issue by using labels.
If information is missing, add a helpful comment and then
If the issue is a question, add the
If the issue is valid but there is no time to troubleshoot it, consider adding the
If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C),
add the applicable
After troubleshooting the issue, please add the Thank you! |
@diemol, what do you think? |
This makes sense. We might have just missed being consistent across images. We should be using |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
What happened?
This is more an inconsistency instead of a bug but it may lead to confusion when mounting a configuration file.
When setting up a Selenium Grid using Docker we can mount a
config.toml
for configuration as shown in the documenation. But the mount point differs in the images. Here is a small table showing the current state:This may lead to configuration errors since the
config.toml
is mounted to a valid location in one container but will be silently ignored in another container where the mount point differs. I added a simple hub-node-setup using docker-compose which shows that.I would suggest to always use the same mount point for
config.toml
and I'm willing to send in a PR but since this can break existing docker setups, I'm not sure what is the best way to change this.Command used to start Selenium Grid with Docker (or Kubernetes)
Relevant log output
Operating System
doesn't matter
Docker Selenium version (image tag)
4.23.0
Selenium Grid chart version (chart version)
no chart involved
The text was updated successfully, but these errors were encountered: