Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement singleton pattern #23

Open
Sequoia opened this issue Mar 8, 2014 · 0 comments
Open

Implement singleton pattern #23

Sequoia opened this issue Mar 8, 2014 · 0 comments
Labels
refactors

Comments

@Sequoia
Copy link
Owner

Sequoia commented Mar 8, 2014

  • Publics & privates are basically in place already, move them into init
  • Return only get & destroy functions on exports object
  • Stop using new or use constructor pattern internally to reduce init cost (probably overkill)
  • Rework bookmarklet code & examples to use get rather than new
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Sequoia