From 988cd9637dba6a891e584fa8e8c54358f0ffb4c2 Mon Sep 17 00:00:00 2001
From: myst404 <secret@example.com>
Date: Thu, 6 Sep 2018 11:01:58 +0200
Subject: [PATCH] Improve hyperlinks handling

---
 helpers/helper.rb      | 13 ++++++-------
 views/report_edit.haml |  2 +-
 2 files changed, 7 insertions(+), 8 deletions(-)

diff --git a/helpers/helper.rb b/helpers/helper.rb
index b8bfc285..da185d02 100644
--- a/helpers/helper.rb
+++ b/helpers/helper.rb
@@ -54,23 +54,22 @@ def find_headers_footers(docx)
 def updateHyperlinks(xmlText)
   retHash = {}
   # Find urls
-  urls = xmlText.scan(/<w:t>{{.*}}<\/w:t>/)
+  urls = xmlText.scan(/<w:t.*>{{.*}}<\/w:t>/)
   # Resources for <Resources> tag
   retHash['urls'] = []
   retHash['id'] = []
-  i = 25
   urls.each do |url|
-    cleanUrl = url.gsub('{{', '').gsub('}}', '').tr(' ', '_')
+    cleanUrl = url.gsub('{{', '').gsub('}}', '').tr(' ', '%20')
     # set resourceId and xmlText
-    resourceId = "r:id=\"rId#{i}\""
+    p_id = "d#{rand(36**7).to_s(36)}"
+    resourceId = "r:id=\"rId#{p_id}\""
     xmlText = xmlText.gsub(url, "<w:hyperlink #{resourceId} w:history=\"1\"><w:r w:rsidRPr=\"00720130\"><w:rPr><w:rStyle w:val=\"Hyperlink\"/></w:rPr>#{cleanUrl}</w:r></w:hyperlink>")
     # remove tags
-    cleanUrl = cleanUrl.gsub('<w:t>', '')
+    cleanUrl = cleanUrl.gsub(/<w:t.*?>/, '')
     cleanUrl = cleanUrl.gsub("<\/w:t>", '')
     # put urls in resources
     retHash['urls'].push(cleanUrl)
-    retHash['id'].push("rId#{i}")
-    i += 1
+    retHash['id'].push("rId#{p_id}")
   end
   retHash['xmlText'] = xmlText
   retHash
diff --git a/views/report_edit.haml b/views/report_edit.haml
index 0fb983c1..62e9d022 100644
--- a/views/report_edit.haml
+++ b/views/report_edit.haml
@@ -39,7 +39,7 @@
                 %label.col-md-3{ :for => "report_name" }
                   Title
               %td{ :style => "width: 70%" }
-                %input#report_name{ :type => "text", :style => "width: 90%", :name => "report_name", :value => "#{@report.report_name}" }
+                %input#report_name{ :type => "text", :style => "width: 90%", :name => "report_name", :value => "#{CGI.unescapeHTML(@report.report_name)}" }
             %tr
               %td{ :style => "width: 30%" }
                 %label.col-md-3{ :for => "assessment_type" }