Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: we need access to LocalStorage and SessionStorage using shaft api #1192

Closed
wesamhamed opened this issue Jul 9, 2023 · 0 comments · Fixed by #1213
Closed

[Feature Request]: we need access to LocalStorage and SessionStorage using shaft api #1192

wesamhamed opened this issue Jul 9, 2023 · 0 comments · Fixed by #1213
Assignees
@MohabMohie
Labels
enhancement New feature or request triage needs to be looked at

Comments

@wesamhamed
Copy link
Contributor

wesamhamed commented Jul 9, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe. Yes

Rather than access to the native Selenium web driver I need shaft support these features natively

LocalStorage local = ((WebStorage) getDriver().getDriver()).getLocalStorage();
local.setItem(tokenName, token);

replace by shaft engine APIs

driver.browser().localStorage()
driver.browser().sessionStorage()
@wesamhamed wesamhamed added enhancement New feature or request triage needs to be looked at labels Jul 9, 2023
@MohabMohie MohabMohie linked a pull request Aug 3, 2023 that will close this issue
implement local and session storage getter #1213
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MohabMohie MohabMohie

Labels
enhancement New feature or request triage needs to be looked at
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

implement local and session storage getter ShaftHQ/SHAFT_ENGINE
2 participants
@wesamhamed @MohabMohie