Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not patch fetch globally #233

Open
emi0x7d1 opened this issue Aug 8, 2024 · 1 comment
Open

Do not patch fetch globally #233

emi0x7d1 opened this issue Aug 8, 2024 · 1 comment

Comments

@emi0x7d1
Copy link

emi0x7d1 commented Aug 8, 2024

It is messing up with dependencies that expect the native fetch function to be there on node.js

Would a patch that removes the usages of the global fetch function and instead imports it from an isomorphic file be accepted?

@djMax
Copy link

djMax commented Jan 5, 2025

Oh my god 100% this. Never ever do this without at the very least some safety switch to turn it off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants