Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails and git dependency #8

Open
oleksii-ti opened this issue Nov 11, 2015 · 1 comment
Open

Rails and git dependency #8

oleksii-ti opened this issue Nov 11, 2015 · 1 comment

Comments

@oleksii-ti
Copy link

in lib/shiphawk/helpers/request.rb Rails module is used thought there is no rails dependency in project

5  module Helpers
6   
7       module Request
8   
9         APP_VERSION = IO.popen(['git', 'rev-parse', 'HEAD', :chdir => Rails.root]).read.chomp
 
40            conn.use :extended_logging, logger: Rails.logger
41  

Also this APP_VERSION = IO.popen(['git', 'rev-parse', 'HEAD', :chdir => Rails.root]).read.chomp means than project could be used only from git directory which is hardly possible for one who going only use it as gem.

@resgraph
Copy link
Contributor

Good catch.

This was copy/paste code from within a Rails project. Should be fixed soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants