Skip to content

Commit

Permalink
fix: add guard for shared side stories
Browse files Browse the repository at this point in the history
Added a guard to prevent accidentally duplicating a series across multiple merge groups because the series is a side story to multiple main stories (e.g. linked to two series which have a sequel/prequel relationship, etc.).
  • Loading branch information
revam committed Feb 4, 2025
1 parent 48ae685 commit e0b473c
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions Shokofin/API/ShokoAPIManager.cs
Original file line number Diff line number Diff line change
Expand Up @@ -1395,6 +1395,16 @@ var sequelRelation in currentRelations
if (sequelSeries.AniDB.AirDate is not { } sequelDate || (sequelRelation.Type is RelationType.Sequel && sequelDate < currentDate))
continue;

if (sequelRelation.Type is RelationType.SideStory) {
var sequelRelations = await ApiClient.GetRelationsForShokoSeries(sequelSeries.Id).ConfigureAwait(false);
sequelRelations = sequelRelations
.Where(relation => relation.Type is RelationType.MainStory && relation.RelatedIDs.Shoko.HasValue)
.OrderBy(relation => relation.RelatedIDs.AniDB)
.ToList();
if (sequelRelations.Count == 0 || sequelRelations[0].RelatedIDs.AniDB != sequelRelation.IDs.AniDB)
continue;
}

var mergeOverride = (
sequelRelation.Type is RelationType.Sequel && (currentConfig.MergeOverride.HasFlag(SeriesMergingOverride.MergeForward) || sequelConfig.MergeOverride.HasFlag(SeriesMergingOverride.MergeBackward))
) || (
Expand Down

0 comments on commit e0b473c

Please sign in to comment.